Wasmtime GitHub notifications bot (Sep 14 2023 at 09:35): Wasmtime GitHub notifications bot (Sep 14 2023 at 09:35):badeend opened PR #7034 from badeend:set-backlog-size-before-listen to bytecodealliance:main:
Allow
set_listen_backlog_sizeto be called before listening. This enables us to pass the backlog value to the initiallistensyscall, which is more widely supported.These changes are in line with the explanation in https://github.com/WebAssembly/wasi-sockets/issues/34
Wasmtime GitHub notifications bot (Sep 14 2023 at 09:35):badeend requested pchickey for a review on PR #7034.
Wasmtime GitHub notifications bot (Sep 14 2023 at 09:35):badeend requested wasmtime-core-reviewers for a review on PR #7034.
Wasmtime GitHub notifications bot (Sep 14 2023 at 09:48):badeend updated PR #7034.
Wasmtime GitHub notifications bot (Sep 14 2023 at 09:54):badeend edited PR #7034:
- Allow
set_listen_backlog_sizeto be called before listening. This enables us to pass the backlog value to the initiallistensyscall, which is more widely supported. This is in line with the explanation in https://github.com/WebAssembly/wasi-sockets/issues/34- Silently clamp the provided backlog value, instead of failing with OutOfMemory.
Wasmtime GitHub notifications bot (Sep 14 2023 at 15:14):alexcrichton submitted PR review:
Seems reasonable to me! I'll defer to Pat or Dan though for more specifics.
Wasmtime GitHub notifications bot (Sep 14 2023 at 15:14):alexcrichton submitted PR review:
Seems reasonable to me! I'll defer to Pat or Dan though for more specifics.
Wasmtime GitHub notifications bot (Sep 14 2023 at 15:14):alexcrichton created PR review comment:
To avoid repeating the definition could this be:
const DEFAULT_BACKLOG: i32 = if cfg!(target_os = "horizon") { 20 } else { 128 };
Wasmtime GitHub notifications bot (Sep 14 2023 at 15:14):alexcrichton created PR review comment:
Or, alternatively, could the default be
None? That way we could let the OS defaults come into play if it's not otherwise specified.
Wasmtime GitHub notifications bot (Sep 14 2023 at 17:57):pchickey requested sunfishcode for a review on PR #7034.
Wasmtime GitHub notifications bot (Sep 16 2023 at 20:21):badeend updated PR #7034.
Wasmtime GitHub notifications bot (Sep 16 2023 at 20:22):badeend submitted PR review.
Wasmtime GitHub notifications bot (Sep 16 2023 at 20:22):badeend created PR review comment:
That's indeed simpler. I've update the code.
Wasmtime GitHub notifications bot (Sep 19 2023 at 17:57):badeend updated PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 15:07):alexcrichton submitted PR review:
Apologies this fell through the cracks @badeend! If you'd like to give this a rebase I'd be happy to merge.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:23):badeend updated PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:25):alexcrichton submitted PR review:
Thanks again and apologies for the delay!
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:25):alexcrichton has enabled auto merge for PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:28):alexcrichton has disabled auto merge for PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:28):badeend updated PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:40):alexcrichton has enabled auto merge for PR #7034.
Wasmtime GitHub notifications bot (Oct 03 2023 at 16:54):sunfishcode submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Oct 03 2023 at 19:06):alexcrichton merged PR #7034.
Last updated: Oct 23 2024 at 20:03 UTC