Stream: git-wasmtime

Topic: wasmtime / PR #7011 Fix character boundary issues in prev...

Wasmtime GitHub notifications bot (Sep 12 2023 at 21:55):

alexcrichton opened PR #7011 from alexcrichton:fix-string-boundary-issues to bytecodealliance:main:

This fixes two separate issues in the preview1-to-preview2 host-side adapter in the wasmtime-wasi crate. Both instances were copying a truncated string to the guest program but the truncation was happening in the middle of a unicode character so truncation now happens on bytes instead of a string.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 12 2023 at 21:55):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7011.

Wasmtime GitHub notifications bot (Sep 12 2023 at 21:55):

alexcrichton requested pchickey for a review on PR #7011.

Wasmtime GitHub notifications bot (Sep 12 2023 at 21:55):

alexcrichton edited PR #7011:

This fixes two separate issues in the preview1-to-preview2 host-side adapter in the wasmtime-wasi crate. Both instances were copying a truncated string to the guest program but the truncation was happening in the middle of a unicode character so truncation now happens on bytes instead of a string.

Closes #7006

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 20 2023 at 16:06):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Sep 20 2023 at 17:00):

pchickey merged PR #7011.

Last updated: Dec 23 2024 at 12:05 UTC