saulecabrera opened PR #7002 from saulecabrera:winch-refactor-masm-regimm
to bytecodealliance:main
:
This change is a small refactoring to some of the MacroAssembler functions to use
Reg
instead ofRegImm
where appropriate (e.g. when the operand is a destination).@elliottt pointed this out while working on https://github.com/bytecodealliance/wasmtime/pull/6982
This change also changes the signature of
float_abs
andfloat_neg
, which can be simplified to take a single register.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
saulecabrera requested abrown for a review on PR #7002.
saulecabrera requested wasmtime-compiler-reviewers for a review on PR #7002.
saulecabrera requested elliottt for a review on PR #7002.
elliottt submitted PR review:
Looks great!
saulecabrera merged PR #7002.
Last updated: Dec 23 2024 at 12:05 UTC