Stream: git-wasmtime

Topic: wasmtime / PR #7002 winch: Use `Reg` where appropriate in...

Wasmtime GitHub notifications bot (Sep 11 2023 at 22:38):

saulecabrera opened PR #7002 from saulecabrera:winch-refactor-masm-regimm to bytecodealliance:main:

This change is a small refactoring to some of the MacroAssembler functions to use Reg instead of RegImm where appropriate (e.g. when the operand is a destination).

@elliottt pointed this out while working on https://github.com/bytecodealliance/wasmtime/pull/6982

This change also changes the signature of float_abs and float_neg, which can be simplified to take a single register.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 11 2023 at 22:38):

saulecabrera requested abrown for a review on PR #7002.

Wasmtime GitHub notifications bot (Sep 11 2023 at 22:38):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #7002.

Wasmtime GitHub notifications bot (Sep 11 2023 at 22:38):

saulecabrera requested elliottt for a review on PR #7002.

Wasmtime GitHub notifications bot (Sep 11 2023 at 23:18):

elliottt submitted PR review:

Looks great!

Wasmtime GitHub notifications bot (Sep 12 2023 at 11:39):

saulecabrera merged PR #7002.

Last updated: Oct 23 2024 at 20:03 UTC