Wasmtime GitHub notifications bot (Sep 11 2023 at 16:06): Wasmtime GitHub notifications bot (Sep 11 2023 at 16:06):dicej opened PR #6993 from dicej:monotonic-clock-subscribe-logic-error to bytecodealliance:main:
When calculating the number of nanoseconds to wait, we should subtract the current time from the deadline, not vice-versa. This was causing guests to sleep indefinitely due to integer underflow.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 11 2023 at 16:06):dicej requested alexcrichton for a review on PR #6993.
Wasmtime GitHub notifications bot (Sep 11 2023 at 16:06):dicej requested wasmtime-core-reviewers for a review on PR #6993.
Wasmtime GitHub notifications bot (Sep 11 2023 at 16:10):alexcrichton submitted PR review:
Thanks! Would it be possible to add a test for this as well?
Wasmtime GitHub notifications bot (Sep 11 2023 at 17:06):dicej updated PR #6993.
Wasmtime GitHub notifications bot (Sep 11 2023 at 17:06):dicej requested wasmtime-default-reviewers for a review on PR #6993.
Wasmtime GitHub notifications bot (Sep 11 2023 at 17:07):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Sep 11 2023 at 17:07):pchickey has enabled auto merge for PR #6993.
Wasmtime GitHub notifications bot (Sep 11 2023 at 18:23):pchickey merged PR #6993.
Last updated: Oct 23 2024 at 20:03 UTC