Stream: git-wasmtime

Topic: wasmtime / PR #6988 riscv64: Remove support for fixed off...

Wasmtime GitHub notifications bot (Sep 10 2023 at 10:18):

afonso360 opened PR #6988 from afonso360:riscv-cleanup-jal to bytecodealliance:main:

:wave: Hey,

This PR removes fixed offset jumps from some instructions in the RISC-V backend. Fixed offset jumps were replaced with labels in #6955. But we still have support for them.

Currently all branch instructions use the BranchTarget struct, that allows a label based jump, or a fixed offset jump.

This PR does the following changes:

• Jal now takes a single MachLabel as it's target
• BrTable similarly now takes a Vec<MachLabel>
• CondBr still uses BranchTarget, but it can only do a label jump, or fallthrough. It can no longer do a fixed offset jump

Since BranchTarget is now only used in CondBr, I've renamed it CondBrTarget.

Wasmtime GitHub notifications bot (Sep 10 2023 at 10:18):

afonso360 requested fitzgen for a review on PR #6988.

Wasmtime GitHub notifications bot (Sep 10 2023 at 10:18):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6988.

Wasmtime GitHub notifications bot (Sep 11 2023 at 14:36):

alexcrichton submitted PR review:

Nice!

Wasmtime GitHub notifications bot (Sep 11 2023 at 15:28):

alexcrichton merged PR #6988.

Last updated: Dec 23 2024 at 12:05 UTC