Stream: git-wasmtime

Topic: wasmtime / PR #6985 cranelift: Fix `v{all,any}_true` and ...

Wasmtime GitHub notifications bot (Sep 09 2023 at 11:50):

afonso360 edited PR #6985:

:wave: Hey,

This PR fixes the v{all,any}_true and vhigh_bits for floats in the cranelift interpreter. Since these are all bitwise operations, the fix was similar for all of them, convert the type to an equivalent sized integer type and proceed with the operation as normal.

Additionally this PR also restricts the return types for vhigh_bits down to scalar integers. It currently allows returning SIMD integer types which looks like an oversight since it clearly states that it returns a scalar integer in the docs. (Let me know if you'd like me to pull this into a separate PR)

Finally, these instructions are also enabled in the fuzzgen fuzzer.

Wasmtime GitHub notifications bot (Sep 09 2023 at 11:50):

afonso360 edited PR #6985:

:wave: Hey,

This PR fixes the v{all,any}_true and vhigh_bits instructions for floats in the cranelift interpreter. Since these are all bitwise operations, the fix was similar for all of them, convert the type to an equivalent sized integer type and proceed with the operation as normal.

Additionally this PR also restricts the return types for vhigh_bits down to scalar integers. It currently allows returning SIMD integer types which looks like an oversight since it clearly states that it returns a scalar integer in the docs. (Let me know if you'd like me to pull this into a separate PR)

Finally, these instructions are also enabled in the fuzzgen fuzzer.

Wasmtime GitHub notifications bot (Sep 09 2023 at 17:42):

alexcrichton submitted PR review:

Thanks!

Wasmtime GitHub notifications bot (Sep 09 2023 at 18:22):

alexcrichton merged PR #6985.

Last updated: Nov 22 2024 at 16:03 UTC