Stream: git-wasmtime

Topic: wasmtime / PR #6967 cranelift: Fix fuzzgen `iconst` encoding

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:12):

timjrd opened PR #6967 from timjrd:fix-fuzz-iconst to bytecodealliance:main:

If this work has been discussed elsewhere:

#6965

Explain why this change is needed:

Since #6850, the immediate of iconst.i32 -2 is encoded in UnaryImm::imm as 0xffff_fffe, and not -2, despite being stored in a signed 64-bit integer. The fuzzing generator for iconst has not been modified accordingly and is still encoding the previous example as -2. This PR fixes that.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:12):

timjrd requested elliottt for a review on PR #6967.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:12):

timjrd requested wasmtime-compiler-reviewers for a review on PR #6967.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:21):

afonso360 submitted PR review:

LGTM! Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:21):

afonso360 has enabled auto merge for PR #6967.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 23:24):

afonso360 merged PR #6967.

Last updated: Nov 22 2024 at 17:03 UTC