Stream: git-wasmtime

Topic: wasmtime / PR #6959 riscv64: Use canonical move instruction

view this post on Zulip Wasmtime GitHub notifications bot (Sep 03 2023 at 11:17):

afonso360 opened PR #6959 from afonso360:riscv-canonical-mov to bytecodealliance:main:

:wave: Hey,

The canonical move instruction on RISC-V is addi rd, rs, 0, however we currently emit ori ... which while it achieves the same thing is technically not optimal as some processors may miss the renaming opportunity. It also disassembles better.

This seems to be a leftover of the AArch64 port that does use or as it's move instruction.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 03 2023 at 11:17):

afonso360 requested fitzgen for a review on PR #6959.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 03 2023 at 11:17):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6959.

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 19:53):

elliottt submitted PR review:

The disassembly is much nicer, thanks Afonso!

view this post on Zulip Wasmtime GitHub notifications bot (Sep 05 2023 at 22:24):

afonso360 merged PR #6959.

Last updated: Nov 22 2024 at 16:03 UTC