Wasmtime GitHub notifications bot (Sep 02 2023 at 14:20): Wasmtime GitHub notifications bot (Sep 02 2023 at 14:20):uweigand opened PR #6957 from uweigand:abi-machine-env to bytecodealliance:main:
The MachineEnv structure contains the allocatable and preferred register sets. This is currently fixed per TargetIsa - however, conceptually these register sets can differ between ABIs on the same ISA.
To allow for this, replace the TargetIsa machine_env routine with an ABIMachineSpec get_machine_env routine. To ensure the structure is still only allocated once, cache it via static OnceLock variables.
No functional change intended.
FYI @cfallin - this is what I suggested in last week's meeting.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 02 2023 at 14:20):uweigand requested elliottt for a review on PR #6957.
Wasmtime GitHub notifications bot (Sep 02 2023 at 14:20):uweigand requested wasmtime-compiler-reviewers for a review on PR #6957.
Wasmtime GitHub notifications bot (Sep 12 2023 at 00:37):cfallin requested cfallin for a review on PR #6957.
Wasmtime GitHub notifications bot (Sep 12 2023 at 00:38):cfallin submitted PR review:
LGTM, thanks a bunch!
(stealing review from @elliottt since discussed in previous Cranelift meeting, hope that's ok!)
Wasmtime GitHub notifications bot (Sep 12 2023 at 18:33):uweigand updated PR #6957.
Wasmtime GitHub notifications bot (Sep 12 2023 at 18:37):cfallin has enabled auto merge for PR #6957.
Wasmtime GitHub notifications bot (Sep 12 2023 at 19:57):cfallin merged PR #6957.
Last updated: Dec 23 2024 at 12:05 UTC