Stream: git-wasmtime

Topic: wasmtime / PR #6948 Some minor fixes and features for WAS...

Wasmtime GitHub notifications bot (Sep 01 2023 at 01:06):

alexcrichton opened PR #6948 from alexcrichton:tcp-echo-server to bytecodealliance:main:

• Use command::add_to_linker in tests to reduce the number of times all the add_to_linker are listed.
• Add all wasi:sockets interfaces currently implemented to both the sync and async command functions (this enables all the interfaces in the CLI for example).
• Use tokio::net::TcpStream::try_io whenever I/O is performed on a socket, ensuring that readable/writable flags are set/cleared appropriately (otherwise once readable a socket is infinitely readable).
• Add a with_ambient_tokio_runtime helper function to use when creating a tokio::net::TcpStream since otherwise it panics due to a lack of active runtime in a synchronous context.
• Add WouldBlock handling to return a 0-length read.
• Add an --inherit-network CLI flag to enable basic usage of sockets in the CLI.

This will conflict a small amount with #6877 but should be easy to resolve, and otherwise this targets different usability points/issues than that PR.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 01 2023 at 01:06):

alexcrichton requested fitzgen for a review on PR #6948.

Wasmtime GitHub notifications bot (Sep 01 2023 at 01:06):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6948.

Wasmtime GitHub notifications bot (Sep 01 2023 at 03:10):

pchickey submitted PR review:

Thanks, this is a very minor conflict with backpressure_2 but no big deal resolving that, since this can land right now.

Wasmtime GitHub notifications bot (Sep 01 2023 at 03:55):

pchickey merged PR #6948.

Last updated: Dec 23 2024 at 12:05 UTC