Stream: git-wasmtime

Topic: wasmtime / PR #6946 Require Wasmtime options come before ...

Wasmtime GitHub notifications bot (Aug 31 2023 at 20:01):

alexcrichton opened PR #6946 from alexcrichton:require-wasmtime-options-first to bytecodealliance:main:

This commit implements a new behavior for the CLI of the wasmtime executable which will require that options for Wasmtime itself come before the wasm module being run. Currently they're allowed to come afterwards, but instead all arguments and flags coming after a module will be interpreted as arguments for the module itself.

This feature has a bit of a storied history at this point, and the breadcrumbs are:

• Originally landed in #6737
• Reverted for 12.0.0 in #6830
• Reverted for 13.0.0 in #6944

This PR is intended to be landed as a sibling of #6925, another independent overhaul of Wasmtime's own options on the CLI, for the Wasmtime 14.0.0 release. More information about the motivation for this change, as well as consequences of the fallout, can be found on #6737.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 09 2023 at 18:03):

alexcrichton has marked PR #6946 as ready for review.

Wasmtime GitHub notifications bot (Sep 09 2023 at 18:04):

alexcrichton requested fitzgen for a review on PR #6946.

Wasmtime GitHub notifications bot (Sep 09 2023 at 18:04):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6946.

Wasmtime GitHub notifications bot (Sep 11 2023 at 16:35):

alexcrichton requested pchickey for a review on PR #6946.

Wasmtime GitHub notifications bot (Sep 11 2023 at 21:16):

alexcrichton requested fitzgen for a review on PR #6946.

Wasmtime GitHub notifications bot (Sep 13 2023 at 17:27):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Sep 13 2023 at 17:43):

alexcrichton updated PR #6946.

Wasmtime GitHub notifications bot (Sep 13 2023 at 17:43):

alexcrichton has enabled auto merge for PR #6946.

Wasmtime GitHub notifications bot (Sep 13 2023 at 18:22):

alexcrichton updated PR #6946.

Wasmtime GitHub notifications bot (Sep 13 2023 at 19:32):

alexcrichton merged PR #6946.

Last updated: Dec 23 2024 at 12:05 UTC