Stream: git-wasmtime

Topic: wasmtime / PR #6945 aarch64: Use `RegScaled*` addressing ...

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:34):

alexcrichton opened PR #6945 from alexcrichton:aarch64-scaled-amode to bytecodealliance:main:

This commit adds a few cases to amode construction on AArch64 for using the RegScaled* variants of AMode. This won't affect wasm due to this only matching the sign-extension happening before the shift, but it should otherwise help non-wasm Cranelift use cases.

Closes #6742

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:34):

alexcrichton requested fitzgen for a review on PR #6945.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6945.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:44):

fitzgen submitted PR review:

r=me with testing request below addressed

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:44):

fitzgen submitted PR review:

r=me with testing request below addressed

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:44):

fitzgen created PR review comment:

Can we add some tests for when the order of the shift vs extend is wrong in the filetests? IIRC we had some historical issues with amodes and doing the extend at the wrong time, so it would be good to get some future-proofing here.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:48):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:48):

alexcrichton created PR review comment:

Indeed! I tried to make sure those existed here and here

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:49):

alexcrichton requested cfallin for a review on PR #6945.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:56):

cfallin submitted PR review:

Looks good to me as well, thanks! Thorough tests definitely appreciated.

Wasmtime GitHub notifications bot (Aug 31 2023 at 19:56):

alexcrichton has enabled auto merge for PR #6945.

Wasmtime GitHub notifications bot (Aug 31 2023 at 20:11):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2023 at 20:11):

fitzgen created PR review comment:

Ah sorry I thought I only saw shift(extend(..)) and not extend(shift(..))

Wasmtime GitHub notifications bot (Aug 31 2023 at 20:11):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2023 at 20:11):

fitzgen created PR review comment:

Thanks!

Wasmtime GitHub notifications bot (Aug 31 2023 at 21:04):

alexcrichton merged PR #6945.

Last updated: Dec 23 2024 at 12:05 UTC