Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40): Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40):alexcrichton opened PR #6944 from alexcrichton:revert-cli-changes to bytecodealliance:main:
This commit is a partial revert of #6737. That change was reverted in #6830 for the 12.0.0 release of Wasmtime and otherwise it's currently slated to get released with the 13.0.0 release of Wasmtime. Discussion at today's Wasmtime meeting concluded that it's best to couple this change with #6925 as a single release rather than spread out across multiple releases. This commit is thus the revert of #6737, although it's a partial revert in that I've kept many of the new tests added to showcase the differences before/after when the change lands.
This means that Wasmtime 13.0.0 will exhibit the same CLI behavior as 12.0.0 and all prior releases. The 14.0.0 release will have both a new CLI and new argument passing semantics. I'll revert this revert (aka re-land #6737) once the 13.0.0 release branch is created and
mainbecomes 14.0.0.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40):alexcrichton requested jameysharp for a review on PR #6944.
Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40):alexcrichton requested wasmtime-core-reviewers for a review on PR #6944.
Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40):alexcrichton requested wasmtime-default-reviewers for a review on PR #6944.
Wasmtime GitHub notifications bot (Aug 31 2023 at 17:40):alexcrichton updated PR #6944.
Wasmtime GitHub notifications bot (Aug 31 2023 at 17:58):jameysharp submitted PR review:
Great, thanks!
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:06):alexcrichton has enabled auto merge for PR #6944.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:58):alexcrichton merged PR #6944.
Last updated: Dec 23 2024 at 12:05 UTC