Stream: git-wasmtime

Topic: wasmtime / PR #6942 Enhance `async` configuration of `bin...

Wasmtime GitHub notifications bot (Aug 31 2023 at 14:30):

alexcrichton opened PR #6942 from alexcrichton:bindgen-some-sync-imports to bytecodealliance:main:

This commit takes a leaf out of wiggle's book to enable bindings generation for async host functions where only some host functions are async instead of all of them. Unlike wiggle however the configuration key is async_except_imports: ["..."] to provide a deny-list instead of an allow-list. This is done thinking that the majority of functions probably want to be async and it's easier to specify a list of synchronous imports instead of all the async ones. This key name also reflects how exports will be async no matter what, and it's just some imports which may be exempted.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 31 2023 at 14:30):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6942.

Wasmtime GitHub notifications bot (Aug 31 2023 at 14:30):

alexcrichton requested pchickey for a review on PR #6942.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:32):

alexcrichton updated PR #6942.

Wasmtime GitHub notifications bot (Aug 31 2023 at 15:32):

alexcrichton edited PR #6942:

This commit takes a leaf out of wiggle's book to enable bindings
generation for async host functions where only some host functions are
async instead of all of them. This enhances the async key with a few
more options:

async: {
    except_imports: ["foo"],
    only_imports: ["bar"],
}

This is beyond what wiggle supports where either an allow-list or
deny-list can be specified (although only one can be specified). This
can be useful if either the list of sync imports or the list of async
imports is small.

Wasmtime GitHub notifications bot (Aug 31 2023 at 16:34):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 31 2023 at 17:44):

alexcrichton merged PR #6942.

Last updated: Oct 23 2024 at 20:03 UTC