Stream: git-wasmtime

Topic: wasmtime / PR #6935 Include Wasm-defined globals and memo...

Wasmtime GitHub notifications bot (Sep 20 2023 at 21:59):

fitzgen edited PR #6935:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Sep 21 2023 at 17:38):

alexcrichton submitted PR review:

Seems reasonable to me, thanks!

One thing I'm missing though, how will this all fit together? While we can dump globals/memories/etc that happen to be in the Store how is it planned to correlate that back to indices within module instances?

Put another way this gives access to private memories/globals which seems required to have core dumps at all, but beyond providing access it doens't provide a great means of figuring out what a Global or a Memory is

Wasmtime GitHub notifications bot (Sep 21 2023 at 17:38):

alexcrichton submitted PR review:

Seems reasonable to me, thanks!

One thing I'm missing though, how will this all fit together? While we can dump globals/memories/etc that happen to be in the Store how is it planned to correlate that back to indices within module instances?

Put another way this gives access to private memories/globals which seems required to have core dumps at all, but beyond providing access it doens't provide a great means of figuring out what a Global or a Memory is

Wasmtime GitHub notifications bot (Sep 21 2023 at 17:38):

alexcrichton created PR review comment:

Could the unsafe here just be scoped to from_wasmtime_memory which I think is the source of that?

Wasmtime GitHub notifications bot (Sep 21 2023 at 19:32):

fitzgen updated PR #6935.

Wasmtime GitHub notifications bot (Sep 21 2023 at 19:33):

fitzgen has enabled auto merge for PR #6935.

Wasmtime GitHub notifications bot (Sep 22 2023 at 15:39):

fitzgen updated PR #6935.

Wasmtime GitHub notifications bot (Sep 22 2023 at 15:39):

fitzgen has enabled auto merge for PR #6935.

Wasmtime GitHub notifications bot (Sep 22 2023 at 16:51):

fitzgen merged PR #6935.

Last updated: Dec 23 2024 at 13:07 UTC