fitzgen edited PR #6935:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton submitted PR review:
Seems reasonable to me, thanks!
One thing I'm missing though, how will this all fit together? While we can dump globals/memories/etc that happen to be in the
Store
how is it planned to correlate that back to indices within module instances?Put another way this gives access to private memories/globals which seems required to have core dumps at all, but beyond providing access it doens't provide a great means of figuring out what a
Global
or aMemory
is
alexcrichton submitted PR review:
Seems reasonable to me, thanks!
One thing I'm missing though, how will this all fit together? While we can dump globals/memories/etc that happen to be in the
Store
how is it planned to correlate that back to indices within module instances?Put another way this gives access to private memories/globals which seems required to have core dumps at all, but beyond providing access it doens't provide a great means of figuring out what a
Global
or aMemory
is
alexcrichton created PR review comment:
Could the
unsafe
here just be scoped tofrom_wasmtime_memory
which I think is the source of that?
fitzgen updated PR #6935.
fitzgen has enabled auto merge for PR #6935.
fitzgen updated PR #6935.
fitzgen has enabled auto merge for PR #6935.
fitzgen merged PR #6935.
Last updated: Nov 22 2024 at 16:03 UTC