Stream: git-wasmtime

Topic: wasmtime / PR #6931 Two fixes for the `-g` (DWARF debug i...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2023 at 11:54):

SingleAccretion opened PR #6931 from SingleAccretion:DI-Fixes to bytecodealliance:main:

Two changes:
1) Fix a small bug where a constant DWARF "block" wasn't handled in transformation.
2) Fix up instruction offsets after code emission to account for branch removal.

See also the commit messages for a bit more detail.

With these two changes, I am able to step through the code generated by the compiler we are working on.

Fixes #3999.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2023 at 12:03):

SingleAccretion submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 30 2023 at 12:03):

SingleAccretion created PR review comment:

It is interesting to note that optimize_branches is invoked after this code one last time and can nominally modify the current buffer pointer, make func_body_len stale, etc. At the same time, for it to remove a branch, that branch needs to point past the end of the function, which doesn't seem possible?

Last updated: Nov 22 2024 at 16:03 UTC