Stream: git-wasmtime

Topic: wasmtime / PR #6927 Remove clippy configuration from repo...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:18):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6927.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:20):

alexcrichton requested jameysharp for a review on PR #6927.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:37):

jameysharp submitted PR review:

Yeah, good call: these annotations aren't buying us anything.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:48):

alexcrichton opened PR #6927 from alexcrichton:remove-clippy to bytecodealliance:main:

Wasmtime's CI does not run clippy so there's no enforcement of this configuration. Additionally the configuration per-crate is not uniformly applied across all of the Wasmtime workspace and is only on some historical crates. Because we don't run clippy in CI this commit removes all of the clippy annotations for allow/warn/deny from the source.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:51):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6927.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 20:51):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6927.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 29 2023 at 21:52):

alexcrichton merged PR #6927.


Last updated: Nov 22 2024 at 17:03 UTC