Wasmtime GitHub notifications bot (Aug 24 2023 at 15:36): Wasmtime GitHub notifications bot (Aug 24 2023 at 15:36):alexcrichton opened PR #6900 from alexcrichton:update-rust to bytecodealliance:main:
After writing this PR I'm instead though left with the question of "should we do this?" In my opinion we should update Rust via one of two mechanisms:
- Preemptively update when anyone has the time after a release is made
- Only update when a feature is desired from the new release
Personally I'm a fan of being in camp (1) but there's points to camp (2) as well. My worry about (2) is that it incentivises not updating and tends to encourage workarounds when there's typically no need to do so since practically everyone is running the latest stable anyway.
Wasmtime GitHub notifications bot (Aug 24 2023 at 15:36):alexcrichton requested elliottt for a review on PR #6900.
Wasmtime GitHub notifications bot (Aug 24 2023 at 15:36):alexcrichton requested wasmtime-default-reviewers for a review on PR #6900.
Wasmtime GitHub notifications bot (Aug 24 2023 at 17:52):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:05):alexcrichton requested wasmtime-core-reviewers for a review on PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:05):alexcrichton requested fitzgen for a review on PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:05):alexcrichton updated PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:06):alexcrichton updated PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:08):alexcrichton updated PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:13):alexcrichton updated PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:18):cfallin submitted PR review:
LGTM for latest updates; thanks!
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:18):cfallin created PR review comment:
While we're here, could we update this for Cranelift as well? We're no longer included in the mozilla-central tree and aren't subject to their Rust version policies anymore; it's probably uncontroversial to say now that Cranelift will follow the same policy as Wasmtime?
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:18):cfallin submitted PR review:
LGTM for latest updates; thanks!
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:21):alexcrichton updated PR #6900.
Wasmtime GitHub notifications bot (Aug 31 2023 at 18:47):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 31 2023 at 19:36):alexcrichton updated PR #6900.
Last updated: Dec 23 2024 at 12:05 UTC