Stream: git-wasmtime

Topic: wasmtime / PR #6892 Rename the wasi-http `struct` module ...

Wasmtime GitHub notifications bot (Aug 23 2023 at 16:54):

elliottt opened PR #6892 from elliottt:trevor/rename-struct-module to bytecodealliance:main:

Rename the struct module to types, so that we don't need to use special syntax to avoid the keyword collision with the name.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 23 2023 at 16:54):

elliottt requested wasmtime-core-reviewers for a review on PR #6892.

Wasmtime GitHub notifications bot (Aug 23 2023 at 16:54):

elliottt requested jameysharp for a review on PR #6892.

Wasmtime GitHub notifications bot (Aug 23 2023 at 17:02):

elliottt updated PR #6892.

Wasmtime GitHub notifications bot (Aug 23 2023 at 17:02):

elliottt requested pchickey for a review on PR #6892.

Wasmtime GitHub notifications bot (Aug 23 2023 at 17:06):

jameysharp submitted PR review:

This is purely an implementation detail, right? Not something that needs to be coordinated with an upstream spec somewhere? If so, this strikes me as an obviously-good change.

Wasmtime GitHub notifications bot (Aug 23 2023 at 20:43):

elliottt merged PR #6892.

Last updated: Nov 22 2024 at 17:03 UTC