Wasmtime GitHub notifications bot (Aug 23 2023 at 14:43): Wasmtime GitHub notifications bot (Aug 23 2023 at 14:43):saulecabrera requested cfallin for a review on PR #6891.
Wasmtime GitHub notifications bot (Aug 23 2023 at 14:43):saulecabrera opened PR #6891 from saulecabrera:winch-use-type-information-for-sizes to bytecodealliance:main:
This change is a small refactor to how we've been handling the operand size
parameter passed to some of theCodeGenContextoperations, namely,
pop_to_regandmove_val_to_reg.Given the more precise value tagging introduced in:
https://github.com/bytecodealliance/wasmtime/pull/6860,
it's now possible to derive the operand size from the type associated to a value
stack entry, which:
- Makes the usage of the functions mentioned above less error prone.
- Allows a simplification of the two function definitions mentioned above.
- Results in better instruction selection in some cases.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 23 2023 at 14:43):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6891.
Wasmtime GitHub notifications bot (Aug 24 2023 at 04:32):cfallin submitted PR review:
This is a nice simplification, thanks! It's nice to see that some x86 code gets a little more compact too without the REX prefixes (because 32-bit moves can be used).
Wasmtime GitHub notifications bot (Aug 24 2023 at 05:17):cfallin merged PR #6891.
Last updated: Dec 23 2024 at 12:05 UTC