Stream: git-wasmtime

Topic: wasmtime / PR #6885 Handle more failures with `--trap-on-...

Wasmtime GitHub notifications bot (Aug 22 2023 at 19:56):

alexcrichton opened PR #6885 from alexcrichton:more-trap-on-grow-failure to bytecodealliance:main:

This debugging tool was missing a few cases about memory.grow or table.grow returning -1, namely when the OS reported failure in the memory.grow case or in the case for tables when the computation overflowed for the new table size. This commit updates the *_grow_failed methods, which were already hooking these errors, to return a Result<()> which enables returning a trap from them as well.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 22 2023 at 19:56):

alexcrichton requested fitzgen for a review on PR #6885.

Wasmtime GitHub notifications bot (Aug 22 2023 at 19:56):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6885.

Wasmtime GitHub notifications bot (Aug 22 2023 at 22:39):

alexcrichton updated PR #6885.

Wasmtime GitHub notifications bot (Aug 23 2023 at 17:15):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Aug 23 2023 at 18:53):

alexcrichton merged PR #6885.

Last updated: Dec 23 2024 at 13:07 UTC