Stream: git-wasmtime

Topic: wasmtime / PR #6883 fuzzgen: Enable `select` with float arms

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 17:34):

afonso360 opened PR #6883 from afonso360:fuzzgen-select to bytecodealliance:main:

:wave: Hey,

This PR enables the select and select_spectre_guard instructions with float arms on fuzzgen. This should have probably been the first thing I checked when looking at why fuzzgen didn't find #6859, but it was pretty much the last :upside_down: .

Even with this it still took a really long time to reproduce the issue, which isn't great. But we can now theoretically find it.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 17:34):

afonso360 requested abrown for a review on PR #6883.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 17:34):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #6883.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 22 2023 at 17:39):

jameysharp submitted PR review:

Have you run this with the icache fuzz target, to check that we have lowerings on all backends? Assuming that's not going to start failing, this is clearly a good idea.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2023 at 23:00):

afonso360 updated PR #6883.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 26 2023 at 23:16):

afonso360 has enabled auto merge for PR #6883.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 27 2023 at 00:08):

afonso360 merged PR #6883.

Last updated: Oct 23 2024 at 20:03 UTC