Wasmtime GitHub notifications bot (Aug 22 2023 at 11:27): Wasmtime GitHub notifications bot (Aug 22 2023 at 11:27):afonso360 opened PR #6879 from afonso360:opt-bitselect to bytecodealliance:main:
:wave: Hey,
While working on #6876, I noticed we don't yet recognize this pattern for bitselects. I've also added the various permutations of this rule since I don't think we rotate inputs on bitwise operations.
Wasmtime GitHub notifications bot (Aug 22 2023 at 11:27):afonso360 requested fitzgen for a review on PR #6879.
Wasmtime GitHub notifications bot (Aug 22 2023 at 11:27):afonso360 requested wasmtime-compiler-reviewers for a review on PR #6879.
Wasmtime GitHub notifications bot (Aug 22 2023 at 11:28):afonso360 edited PR #6879:
:wave: Hey,
While working on #6876, I noticed we don't yet recognize this pattern for bitselects. I've also added the various permutations of this rule since I don't think we rotate inputs on bitwise operations. (And my understanding is that we shouldn't do so)
Wasmtime GitHub notifications bot (Aug 22 2023 at 15:58):fitzgen submitted PR review:
LGTM, but can we please add some runtests as well? Thanks!
A bit of an aside, but it also makes me think that we should make the runtest runner automatically run tests twice, once with optimizations and once without them. Because we want that for every single runtest that exercises any mid-end rewrite rule, and it definitely doesn't hurt for runtests that are just stressing lowering or something.
Wasmtime GitHub notifications bot (Aug 22 2023 at 17:01):afonso360 updated PR #6879.
Wasmtime GitHub notifications bot (Aug 29 2023 at 13:29):afonso360 updated PR #6879.
Wasmtime GitHub notifications bot (Aug 29 2023 at 13:36):afonso360 updated PR #6879.
Wasmtime GitHub notifications bot (Aug 29 2023 at 18:45):jameysharp submitted PR review:
That's a good restriction to adopt for now and a good assortment of new tests. Thanks!
Wasmtime GitHub notifications bot (Aug 29 2023 at 20:36):afonso360 merged PR #6879.
Last updated: Dec 23 2024 at 12:05 UTC