abrown opened PR #6853 from abrown:adopt-upstream2
to bytecodealliance:main
:
This change removes the temporary
*.wit
files and bumps thespec
directory to the latest [wasi-nn] commit. This is now possible because the upstreamspec
repository has all of the updated WIT and WITX bits. Theload_by_name
implementations are left as TODOs for now and will be included in a subsequent PR.One other change is a refactoring: we wrap up some types--
Graph
andExecutionContext
--to avoid passing aroundBox<dyn ...>
. This simplifies some of the code but should not change behavior.[wasi-nn]: https://github.com/WebAssembly/wasi-nn.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
abrown requested jameysharp for a review on PR #6853.
abrown requested wasmtime-core-reviewers for a review on PR #6853.
abrown requested pchickey for a review on PR #6853.
pchickey submitted PR review.
abrown merged PR #6853.
Last updated: Dec 23 2024 at 12:05 UTC