Stream: git-wasmtime

Topic: wasmtime / PR #6853 wasi-nn: update upstream specification

Wasmtime GitHub notifications bot (Aug 16 2023 at 22:24):

abrown opened PR #6853 from abrown:adopt-upstream2 to bytecodealliance:main:

This change removes the temporary *.wit files and bumps the spec directory to the latest [wasi-nn] commit. This is now possible because the upstream spec repository has all of the updated WIT and WITX bits. The load_by_name implementations are left as TODOs for now and will be included in a subsequent PR.

One other change is a refactoring: we wrap up some types--Graph and ExecutionContext--to avoid passing around Box<dyn ...>. This simplifies some of the code but should not change behavior.

[wasi-nn]: https://github.com/WebAssembly/wasi-nn.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 16 2023 at 22:25):

abrown requested jameysharp for a review on PR #6853.

Wasmtime GitHub notifications bot (Aug 16 2023 at 22:25):

abrown requested wasmtime-core-reviewers for a review on PR #6853.

Wasmtime GitHub notifications bot (Aug 16 2023 at 22:25):

abrown requested pchickey for a review on PR #6853.

Wasmtime GitHub notifications bot (Aug 16 2023 at 22:43):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 16 2023 at 23:55):

abrown merged PR #6853.

Last updated: Nov 22 2024 at 16:03 UTC