wasmtime / PR #6851 Add splat simplify opt for various ops · git-wasmtime

This looks great! Thanks for working through this.

I've had a look at the rest of our opcodes and I don't think we are missing any of them (at least for integers)!

I think it's possible to do a transform from splat+icmp into icmp+bmask+splat, but leaving that for a future PR is also OK!

I've also run our fuzzer on this PR for a couple of hours and nothing has come up.

Wasmtime GitHub notifications bot (Aug 17 2023 at 19:05):

afonso360 submitted PR review:

This looks great! Thanks for working through this.

I've had a look at the rest of our opcodes and I don't think we are missing any of them (at least for integers)!

I think it's possible to do a transform from splat+icmp into icmp+bmask+splat, but leaving that for a future PR is also OK! I'm also not sure if this is a good transform to do. Since I think it would be the only one that actually adds instructions rather than reducing them.

I've also run our fuzzer on this PR for a couple of hours and nothing has come up.

Wasmtime GitHub notifications bot (Aug 18 2023 at 04:00):

gurry updated PR #6851.

Wasmtime GitHub notifications bot (Aug 18 2023 at 04:33):

gurry submitted PR review.

Wasmtime GitHub notifications bot (Aug 18 2023 at 04:33):

gurry created PR review comment:

Thanks for spotting that. Removed it.

Wasmtime GitHub notifications bot (Aug 18 2023 at 09:02):

afonso360 merged PR #6851.

Last updated: Nov 22 2024 at 17:03 UTC