Stream: git-wasmtime

Topic: wasmtime / PR #6844 Add support for vector in DataValueEx...

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 06:52):

gurry opened PR #6844 from gurry:issue-6827 to bytecodealliance:main:

Fixes issue #6827

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 06:52):

gurry requested wasmtime-compiler-reviewers for a review on PR #6844.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 06:52):

gurry requested cfallin for a review on PR #6844.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 07:11):

gurry updated PR #6844.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 07:29):

gurry updated PR #6844.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 07:39):

gurry edited PR #6844:

Fixes #6827

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 07:59):

gurry updated PR #6844.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 10:31):

afonso360 submitted PR review:

:wave: Hey,

This looks great! Thanks!

DataValueExt::int() doesn't currently seem to have any tests. Please let me know if I should add any tests for this PR or for DataValueExt::int() in general.

Yeah, we usually test the opcodes via clif tests instead of the internals, so enabling the ineg tests is great!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 10:32):

afonso360 submitted PR review:

:wave: Hey,

This looks great! Thanks for fixing this!

DataValueExt::int() doesn't currently seem to have any tests. Please let me know if I should add any tests for this PR or for DataValueExt::int() in general.

Yeah, we usually test the opcodes via clif tests instead of the internals, so enabling the ineg tests is great!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 14 2023 at 11:21):

afonso360 merged PR #6844.

Last updated: Dec 23 2024 at 12:05 UTC