Stream: git-wasmtime

Topic: wasmtime / PR #6841 winch: Simplify the MacroAssembler an...


view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2023 at 19:55):

saulecabrera opened PR #6841 from saulecabrera:winch-clean-masm-asm to bytecodealliance:main:

This commit prepares for the introduction of float support to Winch. Initially, I intended to include this change as part of the original change supporting floats, but that change is already sizable enough.

This modification simplifies the Assembler and MacroAssembler interfaces, as well as the interaction and responsibilities between them, by:

This change also introduces richer type information for immediates, which results in better instruction selection in some cases, and it's also needed to support floats.

<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2023 at 19:55):

saulecabrera requested cfallin for a review on PR #6841.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 11 2023 at 19:55):

saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6841.

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2023 at 00:22):

cfallin submitted PR review:

LGTM!

view this post on Zulip Wasmtime GitHub notifications bot (Aug 15 2023 at 01:09):

cfallin merged PR #6841.


Last updated: Dec 23 2024 at 12:05 UTC