Wasmtime GitHub notifications bot (Aug 10 2023 at 18:09): Wasmtime GitHub notifications bot (Aug 10 2023 at 18:09):alexcrichton opened PR #6832 from alexcrichton:detect-precompiled to bytecodealliance:main:
This commit adds a new
Engine::detect_precompiledAPI to inspect some bytes and determine if they look like a precompiled artifact of either a core wasm module or component. This is something I'll be using soon in an upcoming refactor of the Wasmtime CLI to support components, but it's something we've also talked about before which can be useful for systems storing both precompiled modules and components.Implementation-wise this looks at the ELF header of the input and determines if it's got all the right flags that Wasmtime sets for the various bits and bobs of our object format.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 10 2023 at 18:10):alexcrichton requested wasmtime-core-reviewers for a review on PR #6832.
Wasmtime GitHub notifications bot (Aug 10 2023 at 18:18):alexcrichton requested pchickey for a review on PR #6832.
Wasmtime GitHub notifications bot (Aug 10 2023 at 20:10):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 10 2023 at 21:01):alexcrichton merged PR #6832.
Last updated: Nov 22 2024 at 16:03 UTC