Wasmtime GitHub notifications bot (Sep 12 2023 at 21:04): Wasmtime GitHub notifications bot (Sep 12 2023 at 21:04):pchickey edited PR #6825:
there's not yet a way to show this test is actually doing what we intend, I'm using CI to see how this runs on all platforms
Reported in #6824
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:05):pchickey edited PR #6825:
I believe this fixes #6824.
Unfortunately it does not appear that CI reproduces the behavior of an actual windows cmd.exe, so we'll need a windows user to test it manually to verify.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:05):pchickey has marked PR #6825 as ready for review.
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:05):pchickey requested alexcrichton for a review on PR #6825.
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:05):pchickey requested wasmtime-core-reviewers for a review on PR #6825.
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:06):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Sep 12 2023 at 21:06):alexcrichton has enabled auto merge for PR #6825.
Wasmtime GitHub notifications bot (Sep 12 2023 at 22:27):alexcrichton merged PR #6825.
Last updated: Nov 22 2024 at 16:03 UTC