Wasmtime GitHub notifications bot (Aug 07 2023 at 17:47): Wasmtime GitHub notifications bot (Aug 07 2023 at 17:47):alexcrichton opened PR #6816 from alexcrichton:remove-wasi-crypto to bytecodealliance:main:
This commit is a follow-up to the discussion on #6732. This removes Wasmtime's implementation of the wasi-crypto proposal from in-tree along with its various support in CI, configuration, etc. See the discussion on #6732 for the full information but at a high level the main reasons for removing the implementation at this time are:
- There is not currently an active maintainer of the Wasmtime integration here for wasi-crypto.
- There are known issues with the code quality of the implementation such as transmutes of guest-owned memory to
&'static mut [u8]and known unsafety in dependencies.- The size and breadth of the dependency tree brings maintenance burden and overhead to managing Wasmtime's dependency tree.
As mentioned on the issue this commit does not mean that Wasmtime doesn't want to implement the wasi-crypto proposal. Instead the "tier 3" status of wasi-crypto needs to be re-attained to be included back in-tree, which would mean resolving the above issues.
Note that this commit is intentionally just after the 13.0.0 branch point which means that this is slated for Wasmtime 14 to be released on September 20.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 07 2023 at 17:47):alexcrichton requested fitzgen for a review on PR #6816.
Wasmtime GitHub notifications bot (Aug 07 2023 at 17:47):alexcrichton requested wasmtime-default-reviewers for a review on PR #6816.
Wasmtime GitHub notifications bot (Aug 07 2023 at 17:47):alexcrichton requested wasmtime-core-reviewers for a review on PR #6816.
Wasmtime GitHub notifications bot (Aug 07 2023 at 21:40):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 07 2023 at 22:21):jameysharp submitted PR review.
Wasmtime GitHub notifications bot (Aug 07 2023 at 22:21):jameysharp created PR review comment:
Go ahead and merge this but I'm noticing that this
cfgattribute should have been deleted entirely when myGuestProfilerwork landed, since that requiresArcand is not behind any feature flags. I actually thought I had fixed that but the git history tells me I did not.
Wasmtime GitHub notifications bot (Aug 08 2023 at 14:40):alexcrichton updated PR #6816.
Wasmtime GitHub notifications bot (Aug 08 2023 at 14:40):alexcrichton has enabled auto merge for PR #6816.
Wasmtime GitHub notifications bot (Aug 08 2023 at 14:40):alexcrichton edited PR #6816:
This commit is a follow-up to the discussion on #6732. This removes Wasmtime's implementation of the wasi-crypto proposal from in-tree along with its various support in CI, configuration, etc. See the discussion on #6732 for the full information but at a high level the main reasons for removing the implementation at this time are:
- There is not currently an active maintainer of the Wasmtime integration here for wasi-crypto.
- There are known issues with the code quality of the implementation such as transmutes of guest-owned memory to
&'static mut [u8]and known unsafety in dependencies.- The size and breadth of the dependency tree brings maintenance burden and overhead to managing Wasmtime's dependency tree.
As mentioned on the issue this commit does not mean that Wasmtime doesn't want to implement the wasi-crypto proposal. Instead the "tier 3" status of wasi-crypto needs to be re-attained to be included back in-tree, which would mean resolving the above issues.
Note that this commit is intentionally just after the 13.0.0 branch point which means that this is slated for Wasmtime 14 to be released on September 20.
Closes #6732
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 08 2023 at 15:16):alexcrichton updated PR #6816.
Wasmtime GitHub notifications bot (Aug 08 2023 at 15:16):alexcrichton has enabled auto merge for PR #6816.
Wasmtime GitHub notifications bot (Aug 08 2023 at 16:41):alexcrichton merged PR #6816.
Last updated: Dec 23 2024 at 12:05 UTC