Wasmtime GitHub notifications bot (Aug 07 2023 at 15:43): Wasmtime GitHub notifications bot (Aug 07 2023 at 15:43):alexcrichton opened PR #6814 from alexcrichton:disable-bb-padding-fuzzing to bytecodealliance:main:
This commit removes the option to generate padding between basic blocks when fuzzing Wasmtime. Over the weekend lots of OOMs were discovered related to this option and its most recent update in #6736. The new OOMs appear to be related to:
- If multiple modules are generated then the configured limits in #6736 aren't relevant because they only cap one module.
- Each imported function generates a new trampoline which has its own set of padding which wasn't previously accounted for.
- Spec tests have a lot of functions and the limits didn't account for this.
While each of these is probably individually fixable I think it's probably not worth the whack-a-mole any more. The
cranelift-fuzzgentarget should cover the relevant cases for padding without the need for Wasmtime's fuzzing to cover it as well.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Aug 07 2023 at 15:43):alexcrichton requested itsrainy for a review on PR #6814.
Wasmtime GitHub notifications bot (Aug 07 2023 at 15:43):alexcrichton requested wasmtime-core-reviewers for a review on PR #6814.
Wasmtime GitHub notifications bot (Aug 09 2023 at 16:51):jameysharp submitted PR review:
Yeah, that's fair: hopefully the Cranelift fuzzing will cover this pretty well.
Wasmtime GitHub notifications bot (Aug 09 2023 at 17:33):alexcrichton merged PR #6814.
Last updated: Dec 23 2024 at 12:05 UTC