Stream: git-wasmtime

Topic: wasmtime / PR #6807 Configure Mach ports vs signals via `...

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:51):

alexcrichton opened PR #6807 from alexcrichton:runtime-macos-signals to bytecodealliance:main:

This commit adds a Config::macos_use_mach_ports configuration option to replace the old posix-signals-on-macos compile-time Cargo feature. This'll make Wasmtime a tad larger on macOS but likely negligibly so. Otherwise this is intended to provide a resolution to #6785 where embedders will be able to use any build of Wasmtime and configure at runtime how trap handling should happen.

Functionally this commit additionally registers a pthread_atfork handler to cause any usage of Wasmtime in the child to panic. This should help head off a known-invalid state in case anyone runs into it in the future.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:51):

alexcrichton requested itsrainy for a review on PR #6807.

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:51):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6807.

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:51):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6807.

Wasmtime GitHub notifications bot (Aug 05 2023 at 15:32):

alexcrichton updated PR #6807.

Wasmtime GitHub notifications bot (Aug 09 2023 at 16:24):

elliottt submitted PR review:

This looks great to me! Thanks for the detailed comment on the ports config!

Wasmtime GitHub notifications bot (Aug 09 2023 at 17:33):

alexcrichton merged PR #6807.

Last updated: Oct 23 2024 at 20:03 UTC