pchickey opened PR #6806 from bytecodealliance:pch/sync_wasi_cli
to bytecodealliance:main
:
Based on top of #6791
See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landedstill TODO: https://github.com/WebAssembly/wasi-io/pull/38
pchickey edited PR #6806:
Based on top of #6791
See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landedstill TODO: https://github.com/WebAssembly/wasi-io/pull/38
and needs test coverage, presently has none
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey edited PR #6806:
See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landedstill TODO: https://github.com/WebAssembly/wasi-io/pull/38
and needs test coverage, presently has none
pchickey edited PR #6806:
This PR synchronizes the wasi:cli package with the upstream spec definition.
As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20
pchickey edited PR #6806:
This PR synchronizes the wasi:cli package with the upstream spec definition.
As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20The changes arriving downstream in this change are
- eliminating the patchwork of "temporary" fixes to the cli definition as the wit language evolved alongside the implementation. This involved calling the package "cli-base" in the wasmtime repo, and putting world definitions separately in a "preview" package.
- adding implementations of the
terminal-{input, output, stdin, stdout, stderr}
functions to the cli implementation, which allows us to implementisatty
, bringing preview2's view of stdio to parity with preview 1, where fd_filestat_get could be used to determine whether stdio were ttys. I made some changes in wasi-tests to exercise this functionality to show that it works in all 5 of our WASI implementations. (yes i roll my eyes every time i type all 5 wasi implementations to, because i wrote them, what have i done. what did they do to us)
pchickey has marked PR #6806 as ready for review.
pchickey requested wasmtime-core-reviewers for a review on PR #6806.
pchickey requested fitzgen for a review on PR #6806.
pchickey requested wasmtime-default-reviewers for a review on PR #6806.
pchickey updated PR #6806.
pchickey requested elliottt for a review on PR #6806.
elliottt submitted PR review:
This looks great!
elliottt updated PR #6806.
elliottt has enabled auto merge for PR #6806.
elliottt updated PR #6806.
pchickey updated PR #6806.
pchickey updated PR #6806.
pchickey edited PR #6806:
This PR synchronizes the wasi:cli package with the upstream spec definition.
As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20The changes arriving downstream in this change are
- eliminating the patchwork of "temporary" fixes to the cli definition as the wit language evolved alongside the implementation. This involved calling the package "cli-base" in the wasmtime repo, and putting world definitions separately in a "preview" package.
- adding implementations of the
terminal-{input, output, stdin, stdout, stderr}
functions to the cli implementation, which allows us to implementisatty
, bringing preview2's view of stdio to parity with preview 1, where fd_filestat_get could be used to determine whether stdio were ttys. I made some changes in wasi-tests to exercise this functionality to show that it works in all 5 of our WASI implementations. (yes i roll my eyes every time i type all 5 wasi implementations too. because i wrote them. what have i done. what did they do to us)
elliottt merged PR #6806.
Last updated: Dec 23 2024 at 12:05 UTC