wasmtime / PR #6806 Sync wasi-cli with wit definitions in... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #6806 Sync wasi-cli with wit definitions in...

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:50):

pchickey opened PR #6806 from bytecodealliance:pch/sync_wasi_cli to bytecodealliance:main:

Based on top of #6791

See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landed

still TODO: https://github.com/WebAssembly/wasi-io/pull/38

Wasmtime GitHub notifications bot (Aug 04 2023 at 23:51):

pchickey edited PR #6806:

Based on top of #6791

See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landed

still TODO: https://github.com/WebAssembly/wasi-io/pull/38
and needs test coverage, presently has none

Wasmtime GitHub notifications bot (Aug 08 2023 at 23:50):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 09 2023 at 01:21):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 09 2023 at 15:52):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 10 2023 at 02:07):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 21:03):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 21:03):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 21:49):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:18):

pchickey edited PR #6806:

See also:
https://github.com/WebAssembly/wasi-cli/pull/19 - pending
https://github.com/WebAssembly/wasi-cli/pull/20 - landed

still TODO: https://github.com/WebAssembly/wasi-io/pull/38
and needs test coverage, presently has none

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:20):

pchickey edited PR #6806:

This PR synchronizes the wasi:cli package with the upstream spec definition.

As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:24):

pchickey edited PR #6806:

This PR synchronizes the wasi:cli package with the upstream spec definition.

As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20

The changes arriving downstream in this change are

eliminating the patchwork of "temporary" fixes to the cli definition as the wit language evolved alongside the implementation. This involved calling the package "cli-base" in the wasmtime repo, and putting world definitions separately in a "preview" package.

adding implementations of the terminal-{input, output, stdin, stdout, stderr} functions to the cli implementation, which allows us to implement isatty, bringing preview2's view of stdio to parity with preview 1, where fd_filestat_get could be used to determine whether stdio were ttys. I made some changes in wasi-tests to exercise this functionality to show that it works in all 5 of our WASI implementations. (yes i roll my eyes every time i type all 5 wasi implementations to, because i wrote them, what have i done. what did they do to us)

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:25):

pchickey has marked PR #6806 as ready for review.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:25):

pchickey requested wasmtime-core-reviewers for a review on PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:25):

pchickey requested fitzgen for a review on PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:25):

pchickey requested wasmtime-default-reviewers for a review on PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:42):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:43):

pchickey requested elliottt for a review on PR #6806.

Wasmtime GitHub notifications bot (Aug 14 2023 at 23:44):

elliottt submitted PR review:

This looks great!

Wasmtime GitHub notifications bot (Aug 15 2023 at 00:16):

elliottt updated PR #6806.

Wasmtime GitHub notifications bot (Aug 15 2023 at 00:16):

elliottt has enabled auto merge for PR #6806.

Wasmtime GitHub notifications bot (Aug 15 2023 at 01:28):

elliottt updated PR #6806.

Wasmtime GitHub notifications bot (Aug 15 2023 at 15:31):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 15 2023 at 15:32):

pchickey updated PR #6806.

Wasmtime GitHub notifications bot (Aug 15 2023 at 15:33):

pchickey edited PR #6806:

This PR synchronizes the wasi:cli package with the upstream spec definition.

As part of this PR I upstreamed changes from the wasmtime repo:
https://github.com/WebAssembly/wasi-cli/pull/19
https://github.com/WebAssembly/wasi-cli/pull/20

The changes arriving downstream in this change are

eliminating the patchwork of "temporary" fixes to the cli definition as the wit language evolved alongside the implementation. This involved calling the package "cli-base" in the wasmtime repo, and putting world definitions separately in a "preview" package.

adding implementations of the terminal-{input, output, stdin, stdout, stderr} functions to the cli implementation, which allows us to implement isatty, bringing preview2's view of stdio to parity with preview 1, where fd_filestat_get could be used to determine whether stdio were ttys. I made some changes in wasi-tests to exercise this functionality to show that it works in all 5 of our WASI implementations. (yes i roll my eyes every time i type all 5 wasi implementations too. because i wrote them. what have i done. what did they do to us)

Wasmtime GitHub notifications bot (Aug 15 2023 at 16:58):

elliottt merged PR #6806.

Last updated: Nov 22 2024 at 17:03 UTC