Stream: git-wasmtime

Topic: wasmtime / PR #6802 Add a bindgen test that exercises usi...

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:37):

elliottt opened PR #6802 from elliottt:trevor/trappable-error-test-multiple-modules to bytecodealliance:main:

Add a test for the changes in #6795 to trappable_error_type argument of the host bindgen! macro. The test uses an error type defined in a different interface as a trappable_error_type, and verifies that the code generator handles that by lifting those result types into anyhow::Error.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:37):

elliottt requested alexcrichton for a review on PR #6802.

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:37):

elliottt requested wasmtime-core-reviewers for a review on PR #6802.

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:37):

elliottt requested pchickey for a review on PR #6802.

Wasmtime GitHub notifications bot (Aug 03 2023 at 22:39):

elliottt edited PR #6802:

Add a test for the changes in #6795 to trappable_error_type argument of the host bindgen! macro. The test uses an error type defined in a different interface as a trappable_error_type, and verifies that the code generator handles that by lifting those result types into anyhow::Error.

The component introduced in this test doesn't make use of multiple modules, and is a complete copy of the component used in the previous enum_error test. This works out because of subtyping, but still allows us to test the interface generated by the bindgen! macro.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 04 2023 at 12:38):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Aug 04 2023 at 13:20):

alexcrichton merged PR #6802.

Last updated: Oct 23 2024 at 20:03 UTC