Stream: git-wasmtime

Topic: wasmtime / PR #6795 Resolve trappable error types with fu...

Wasmtime GitHub notifications bot (Aug 03 2023 at 00:27):

elliottt opened PR #6795 from elliottt:trevor/trappable-types to bytecodealliance:main:

Switch to parsing the trappable_error_type field of the bindgen! macro to expect the first part of the path to be a wit package path. Instead of types::error: MyError, you would now pass "namespace:package/types"::error: MyError. This allows us to resolve the referenced type in wit without ambiguity, when it's used across interfaces.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Aug 03 2023 at 00:27):

elliottt requested jameysharp for a review on PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 00:27):

elliottt requested wasmtime-core-reviewers for a review on PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 00:27):

elliottt requested wasmtime-default-reviewers for a review on PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 00:28):

elliottt requested pchickey for a review on PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 16:25):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 16:38):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 16:52):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 17:05):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 17:07):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 17:12):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 17:20):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Aug 03 2023 at 18:27):

elliottt updated PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 18:27):

elliottt has enabled auto merge for PR #6795.

Wasmtime GitHub notifications bot (Aug 03 2023 at 20:53):

pchickey merged PR #6795.

Last updated: Nov 22 2024 at 16:03 UTC