elliottt opened PR #6795 from elliottt:trevor/trappable-types
to bytecodealliance:main
:
Switch to parsing the
trappable_error_type
field of thebindgen!
macro to expect the first part of the path to be a wit package path. Instead oftypes::error: MyError
, you would now pass"namespace:package/types"::error: MyError
. This allows us to resolve the referenced type in wit without ambiguity, when it's used across interfaces.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt requested jameysharp for a review on PR #6795.
elliottt requested wasmtime-core-reviewers for a review on PR #6795.
elliottt requested wasmtime-default-reviewers for a review on PR #6795.
elliottt requested pchickey for a review on PR #6795.
elliottt updated PR #6795.
elliottt updated PR #6795.
elliottt updated PR #6795.
elliottt updated PR #6795.
elliottt updated PR #6795.
elliottt updated PR #6795.
pchickey submitted PR review.
elliottt updated PR #6795.
elliottt has enabled auto merge for PR #6795.
pchickey merged PR #6795.
Last updated: Dec 23 2024 at 12:05 UTC