Wasmtime GitHub notifications bot (Jul 31 2023 at 17:52): Wasmtime GitHub notifications bot (Jul 31 2023 at 17:52):fitzgen requested wasmtime-core-reviewers for a review on PR #6789.
Wasmtime GitHub notifications bot (Jul 31 2023 at 17:52):fitzgen opened PR #6789 from fitzgen:resources-required to bytecodealliance:main:
Returns a summary of the resources required to instantiate this module or component.
Potential uses of the returned information:
Determining whether your pooling allocator configuration supports instantiating this module.
Deciding how many of which
Moduleyou want to instantiate within a fixed amount of resources, e.g. determining whether to create 5 instances of module X or 10 instances of module Y.Part of #6627.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 31 2023 at 17:52):fitzgen requested pchickey for a review on PR #6789.
Wasmtime GitHub notifications bot (Jul 31 2023 at 23:26):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jul 31 2023 at 23:26):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Jul 31 2023 at 23:26):pchickey created PR review comment:
I expect that this means, for all components using the wasi-preview1-component-adapter (which, for now, is approximately all "real world" components), we won't be able to use this estimator. How much effort would it be to detect and handle the simplest cases of modules importing a memory?
Wasmtime GitHub notifications bot (Jul 31 2023 at 23:36):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 31 2023 at 23:36):fitzgen created PR review comment:
If the adapter is still part of this component graph, then everything should be fine and this method will work today as-is.
If the adapter is a module that the component graph imports from the host, then there really isn't much we can do here. An imported module could define zero or five memories, we have no way of telling how many it will need without actually having the module.
Wasmtime GitHub notifications bot (Aug 01 2023 at 00:04):pchickey created PR review comment:
got it! thanks. I misunderstood the way in which
Importwas being used here.
Wasmtime GitHub notifications bot (Aug 01 2023 at 00:04):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Aug 01 2023 at 00:05):pchickey edited PR review comment.
Wasmtime GitHub notifications bot (Aug 01 2023 at 00:05):pchickey edited PR review comment.
Wasmtime GitHub notifications bot (Aug 01 2023 at 16:06):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Aug 01 2023 at 16:06):fitzgen created PR review comment:
Ah, yeah this is after the component graph has been collapsed/inlined into a single thing, so imports at this layer are imports into the component graph, not between modules within the same component graph.
Wasmtime GitHub notifications bot (Aug 01 2023 at 20:03):fitzgen updated PR #6789.
Wasmtime GitHub notifications bot (Aug 01 2023 at 20:03):fitzgen has enabled auto merge for PR #6789.
Wasmtime GitHub notifications bot (Aug 01 2023 at 21:19):fitzgen merged PR #6789.
Last updated: Nov 22 2024 at 16:03 UTC