Stream: git-wasmtime

Topic: wasmtime / PR #6777 Update the wasm-tools family of crate...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 15:48):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 15:48):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 15:48):

alexcrichton requested pchickey for a review on PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 15:48):

alexcrichton opened PR #6777 from alexcrichton:update-wasm-tools to bytecodealliance:main:

This commit updates the wasm-tools family of crates which notably brings in a change to disallow empty types in the component model. There were a number of tests and fuzz-related things to update, but the "main" change here is that the stream-error type in WASI is growing a dummy: u32 field as a simple way to keep things compiling. This'll also hopefully emphasize that this is a transitionary state where it'll get updated in the future to be a non-empty type.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:50):

pchickey submitted PR review:

I had never noticed that dead wit code, thanks

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:54):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:54):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:54):

peterhuene created PR review comment:

    /// TODO: need to figure out the actual contents of this error. Used to be

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:54):

peterhuene created PR review comment:

For other reviewers: these wit files are no longer needed as the test programs already put it from the crates/wasi/wit directory.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 17:56):

peterhuene edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:09):

alexcrichton updated PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:10):

alexcrichton has enabled auto merge for PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:55):

alexcrichton has disabled auto merge for PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:55):

alexcrichton closed without merge PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:55):

alexcrichton reopened PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 18:56):

alexcrichton has enabled auto merge for PR #6777.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 26 2023 at 20:02):

alexcrichton merged PR #6777.

Last updated: Oct 23 2024 at 20:03 UTC