Stream: git-wasmtime

Topic: wasmtime / PR #6771 Ignore async_stack_size if async_supp...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:18):

guregu opened PR #6771 from guregu:async_stack_size_fix to bytecodealliance:main:

Fixes an issue where max_wasm_stack was being validated against async_stack_size when async_support was disabled, discussed in #6762.

I added a really simple test. I wasn't sure where to put it, let me know if there's a better spot for it (or some way to avoid the magic number of 8MB).

Background: wasmtime-go is currently panicking when trying to set the stack size (see: https://github.com/bytecodealliance/wasmtime-go/issues/182).

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:18):

guregu requested wasmtime-core-reviewers for a review on PR #6771.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:18):

guregu requested fitzgen for a review on PR #6771.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:21):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:21):

alexcrichton has enabled auto merge for PR #6771.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 16:21):

fitzgen submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 25 2023 at 17:40):

alexcrichton merged PR #6771.

Last updated: Oct 23 2024 at 20:03 UTC