wasmtime / PR #6770 Change preview2 builder methods to us... · git-wasmtime

Stream: git-wasmtime

Topic: wasmtime / PR #6770 Change preview2 builder methods to us...

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:36):

alexcrichton opened PR #6770 from alexcrichton:mut-builder to bytecodealliance:main:

This commit changes the WasiCtxBuilder for preview2 to use a builder pattern more similar to std::process::Command where methods take &mut self and return &mut Self instead of taking self and returning Self. This pattern enables more easily building up configuration over time throughout code where ownership transfer might otherwise be awkward.

A small caveat to this is that the ergonomics of this pattern only really work out well if the final "build" method takes &mut self as well. In this situation it's difficult to try to figure out what's supposed to happen if this method is called twice, so I left it to panic for now so we can more easily update it in the future possibly.

I'll also note that the original motivations for this come from the upgrade at https://github.com/fermyon/spin/pull/1678

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:36):

alexcrichton requested jameysharp for a review on PR #6770.

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:36):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6770.

Wasmtime GitHub notifications bot (Jul 25 2023 at 15:58):

pchickey requested pchickey for a review on PR #6770.

Wasmtime GitHub notifications bot (Jul 25 2023 at 20:31):

alexcrichton closed without merge PR #6770.