Stream: git-wasmtime

Topic: wasmtime / PR #6769 Implement component-to-component call...

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:19):

alexcrichton opened PR #6769 from alexcrichton:fact-resources to bytecodealliance:main:

This fills out support in FACT in Wasmtime to support component-to-component calls that use resources. This ended up being relatively simple as it's "just" a matter of moving resources between tables which at this time bottoms out in calls to the host. These new trampolines are are relatively easy to add after #6751 which helps keep this change contained.

Closes #6696

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:19):

alexcrichton requested fitzgen for a review on PR #6769.

Wasmtime GitHub notifications bot (Jul 25 2023 at 14:19):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6769.

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen submitted PR review:

r=me with nitpicks

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen submitted PR review:

r=me with nitpicks

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen created PR review comment:

Perhaps time to rename this file to component/libcalls.rs.

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen created PR review comment:

Naming suggestion: translate_resource_libcall?

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen created PR review comment:

A haiku:

comment forgotten
lonely and so incomplete
TODO for Alex

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:05):

fitzgen created PR review comment:

This has come up a few times now over the last couple PRs, time for an EntityType::unwrap_function method?

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:29):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:29):

alexcrichton created PR review comment:

Oh dear I'm sorry
Thank you Nick for your review
I'm caught red-handed

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:36):

alexcrichton updated PR #6769.

Wasmtime GitHub notifications bot (Jul 25 2023 at 16:36):

alexcrichton has enabled auto merge for PR #6769.

Wasmtime GitHub notifications bot (Jul 25 2023 at 17:45):

alexcrichton merged PR #6769.

Last updated: Oct 23 2024 at 20:03 UTC