Stream: git-wasmtime

Topic: wasmtime / PR #6763 Fix flaky tests in preview2 streams

Wasmtime GitHub notifications bot (Jul 24 2023 at 21:52):

pchickey opened PR #6763 from bytecodealliance:pch/preview2_streams_flaky_tests to bytecodealliance:main:

#6556 introduced (at least) 2 flaky tests:

• I made a bug in the sink_write_stream test in pipes. This test has been fixed, and the comment describes the race.
• poll_oneoff_stdio is failing non-deterministically in CI. We have only observed the failures in macos, but we don't yet have a way to reproduce this bug. The test is marked as ignore on macos for now.

Wasmtime GitHub notifications bot (Jul 24 2023 at 21:52):

pchickey requested fitzgen for a review on PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 21:52):

pchickey requested wasmtime-core-reviewers for a review on PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:05):

alexcrichton has enabled auto merge for PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:38):

pchickey updated PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:39):

pchickey edited PR #6763:

#6556 introduced (at least) 2 flaky tests:

• I made a bug in the sink_write_stream test in pipes. This test has been fixed, and the comment describes the race.
• poll_oneoff_stdio is failed nondeterministically in the wasi-preview2-components-sync suite. We found a typo in the sync-to-async translation that caused this bug.

Thanks @silentbicycle, we used autoclave to reproduce this after a few hundred iterations:

RUST_LOG=wasmtime_wasi=trace autoclave cargo test -p test-programs --features test_programs --test wasi-preview2-components-sync -- poll_oneoff_stdio --nocapture

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:39):

pchickey requested alexcrichton for a review on PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:40):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 24 2023 at 22:42):

pchickey has enabled auto merge for PR #6763.

Wasmtime GitHub notifications bot (Jul 24 2023 at 23:39):

pchickey merged PR #6763.

Last updated: Dec 23 2024 at 13:07 UTC