Wasmtime GitHub notifications bot (Jul 21 2023 at 16:22): Wasmtime GitHub notifications bot (Jul 21 2023 at 16:22):alexcrichton opened PR #6757 from alexcrichton:check-minimal-versions to bytecodealliance:main:
This commit is an attempt to add another CI check for Wasmtime to ensure that the minimum version bounds on all of our dependencies are accurate. This is not a stable feature of Cargo and thus requires usage of nightly. Additionally one of the reasons it's not stable is that the DX is not great as many minimal-versions errors come from transitive dependencies that we can't do anything about. Nevertheless I figure it might be good to try out having it on CI and see how it fares.
This is inspired by #6755 where we picked up a dependency on a newer version of
system-interfacebut forgot to update the minimum version bound. Whether or not this prevents the issue or causes too many headaches is I think yet to be seen.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 21 2023 at 16:22):alexcrichton has marked PR #6757 as ready for review.
Wasmtime GitHub notifications bot (Jul 21 2023 at 16:22):alexcrichton requested itsrainy for a review on PR #6757.
Wasmtime GitHub notifications bot (Jul 21 2023 at 16:22):alexcrichton requested wasmtime-default-reviewers for a review on PR #6757.
Wasmtime GitHub notifications bot (Jul 21 2023 at 16:28):alexcrichton updated PR #6757.
Wasmtime GitHub notifications bot (Jul 21 2023 at 20:20):itsrainy submitted PR review:
This looks good to me! What will this look like when it fails? Is there a place we could add a message saying "you probably forgot to update X dependency", or will that be apparent from the
cargo checkoutput?
Wasmtime GitHub notifications bot (Jul 24 2023 at 15:28):alexcrichton updated PR #6757.
Wasmtime GitHub notifications bot (Feb 22 2024 at 21:37):alexcrichton commented on PR #6757:
I'm going to close this for now and we can always reconsider if it crops up again.
Wasmtime GitHub notifications bot (Feb 22 2024 at 21:37):alexcrichton closed without merge PR #6757.
Last updated: Dec 23 2024 at 12:05 UTC