Stream: git-wasmtime

Topic: wasmtime / PR #6749 Cranelift: Implement tail calls on ri...

Wasmtime GitHub notifications bot (Jul 19 2023 at 17:25):

fitzgen opened PR #6749 from fitzgen:riscv64-tail-calls to bytecodealliance:main:

Builds on top of https://github.com/bytecodealliance/wasmtime/pull/6723

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 19 2023 at 17:25):

fitzgen requested elliottt for a review on PR #6749.

Wasmtime GitHub notifications bot (Jul 19 2023 at 17:25):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6749.

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:13):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:13):

elliottt created PR review comment:

Should riscv64 also have tail calls enabled when fuzzing?

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:46):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:46):

fitzgen created PR review comment:

Yes it should. Good catch, thanks!

Wasmtime GitHub notifications bot (Jul 21 2023 at 20:11):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 21 2023 at 20:11):

afonso360 created PR review comment:

I've been running this on the fuzzer, so far nothing has shown up yet.

Wasmtime GitHub notifications bot (Jul 24 2023 at 16:01):

fitzgen updated PR #6749.

Wasmtime GitHub notifications bot (Jul 24 2023 at 16:03):

fitzgen requested elliottt for a review on PR #6749.

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:06):

elliottt submitted PR review:

Looks great!

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:06):

elliottt submitted PR review:

Looks great!

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:06):

elliottt created PR review comment:

Was this test new since the aarch64 pr landed?

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:06):

elliottt created PR review comment:

    for i in (0..new_stack_words).rev() {

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:08):

fitzgen created PR review comment:

No, I just forgot to enable the tests in that PR.

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:08):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:08):

fitzgen updated PR #6749.

Wasmtime GitHub notifications bot (Jul 24 2023 at 18:09):

fitzgen has enabled auto merge for PR #6749.

Wasmtime GitHub notifications bot (Jul 24 2023 at 20:43):

fitzgen merged PR #6749.

Last updated: Dec 23 2024 at 12:05 UTC