Stream: git-wasmtime

Topic: wasmtime / PR #6745 Change the call to unwrap to except w...

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 16:23):

MindSwipe opened PR #6745 from MindSwipe:feature/c-api-linker-expect to bytecodealliance:main:

Fixes #6744, also fixes https://github.com/bytecodealliance/wasmtime-dotnet/issues/265

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 16:23):

MindSwipe requested alexcrichton for a review on PR #6745.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 16:23):

MindSwipe requested wasmtime-core-reviewers for a review on PR #6745.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 19:53):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 20:05):

peterhuene created PR review comment:

                .expect("failed to define WASI on linker; did you set a WASI configuration in the store?")

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 20:05):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 18 2023 at 20:05):

peterhuene submitted PR review:

Just a minor requested change to make it easier to understand where the configuration needs to be set.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 20:28):

peterhuene updated PR #6745.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 20:28):

peterhuene submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 20:29):

peterhuene has enabled auto merge for PR #6745.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 20:30):

peterhuene updated PR #6745.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 19 2023 at 21:45):

peterhuene merged PR #6745.

Last updated: Dec 23 2024 at 12:05 UTC