Stream: git-wasmtime

Topic: wasmtime / PR #6731 Dependency gardening for Wasmtime

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:34):

alexcrichton opened PR #6731 from alexcrichton:update-deps to bytecodealliance:main:

This PR is a series of commits to handle a number of updates to dependencies in Wasmtime. I've separated out each dependency by commit to see what's going on. The biggest upgrades were syn 2.x.x, clap 4.x.x, and bitflags 2.x.x. All the other updates were mostly minor.

In terms of vetting I've added a number of new trusted annotations crates that are authored by those we already trust (e.g. me, Dan, epage, etc). I've additionally performed a variety of audits for new versions that aren't covered by our preexisting policies.

At some point we need to revisit cargo deny's configuration because we have quite a few duplicated dependencies which aren't being caught by cargo deny and I'm not entirely sure why. I think that our ignore list is too aggressive and/or not interacting well with how cargo deny works. I'll try to poke at this in the future.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:34):

alexcrichton requested fitzgen for a review on PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:34):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:34):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:34):

alexcrichton requested wasmtime-default-reviewers for a review on PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 21:53):

alexcrichton updated PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 22:16):

sunfishcode submitted PR review:

LGTM, with one comment:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 22:16):

sunfishcode submitted PR review:

LGTM, with one comment:

view this post on Zulip Wasmtime GitHub notifications bot (Jul 14 2023 at 22:16):

sunfishcode created PR review comment:

from_bits_truncate silently drops unknown flags; should this use from_bits and return an InvalidFlagValue if it doesn't succeed?

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 01:19):

alexcrichton updated PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 01:19):

alexcrichton has enabled auto merge for PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 01:55):

alexcrichton updated PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 01:55):

alexcrichton has enabled auto merge for PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 02:34):

alexcrichton updated PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 02:34):

alexcrichton has enabled auto merge for PR #6731.

view this post on Zulip Wasmtime GitHub notifications bot (Jul 15 2023 at 03:38):

alexcrichton merged PR #6731.

Last updated: Dec 23 2024 at 12:05 UTC