Stream: git-wasmtime

Topic: wasmtime / PR #6728 Disable some icmp optimizations for v...

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:15):

alexcrichton opened PR #6728 from alexcrichton:fix-vector-icmp to bytecodealliance:main:

This is a fix for #6725 where some icmp rules written for scalars were accidentally firing for vectors and generating invalid code, namely producing an iconst of a vector type.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:15):

alexcrichton requested elliottt for a review on PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:15):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:15):

alexcrichton requested pchickey for a review on PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:15):

alexcrichton requested wasmtime-core-reviewers for a review on PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:42):

alexcrichton updated PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:49):

elliottt submitted PR review:

Looks good to me!

Wasmtime GitHub notifications bot (Jul 14 2023 at 17:51):

alexcrichton has enabled auto merge for PR #6728.

Wasmtime GitHub notifications bot (Jul 14 2023 at 18:42):

alexcrichton merged PR #6728.

Last updated: Oct 23 2024 at 20:03 UTC