Stream: git-wasmtime

Topic: wasmtime / PR #6723 Cranelift: Get tail calls working on ...

Wasmtime GitHub notifications bot (Jul 13 2023 at 19:01):

fitzgen opened PR #6723 from fitzgen:aarch64-tail-calls to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 13 2023 at 19:01):

fitzgen requested cfallin for a review on PR #6723.

Wasmtime GitHub notifications bot (Jul 13 2023 at 19:01):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #6723.

Wasmtime GitHub notifications bot (Jul 13 2023 at 20:14):

fitzgen requested jameysharp for a review on PR #6723.

Wasmtime GitHub notifications bot (Jul 13 2023 at 22:53):

jameysharp submitted PR review:

I haven't reviewed all of this but ran out of time for today. Overall I think it's right but would like somebody else to take a look. For now I have one minor suggestion.

Wasmtime GitHub notifications bot (Jul 13 2023 at 22:53):

jameysharp submitted PR review:

I haven't reviewed all of this but ran out of time for today. Overall I think it's right but would like somebody else to take a look. For now I have one minor suggestion.

Wasmtime GitHub notifications bot (Jul 13 2023 at 22:53):

jameysharp created PR review comment:

Since the immediate is a 0, this might as well be an Add. At that point I think the disassembly will show it as a mov which would be a little easier to understand.

Wasmtime GitHub notifications bot (Jul 14 2023 at 20:43):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 14 2023 at 20:43):

fitzgen created PR review comment:

I originally had it as an add and changed it to a sub to try and get the disassembly to show a mov. Neither version worked to get that. shrug

Wasmtime GitHub notifications bot (Jul 14 2023 at 20:52):

fitzgen updated PR #6723.

Wasmtime GitHub notifications bot (Jul 14 2023 at 21:28):

afonso360 submitted PR review.

Wasmtime GitHub notifications bot (Jul 14 2023 at 21:28):

afonso360 created PR review comment:

We can use Inst::gen_move here right? Hopefully that gives us an actual mov.

Wasmtime GitHub notifications bot (Jul 17 2023 at 16:57):

fitzgen updated PR #6723.

Wasmtime GitHub notifications bot (Jul 17 2023 at 16:58):

fitzgen created PR review comment:

D'oh, we can just use Inst::Move here.

Wasmtime GitHub notifications bot (Jul 17 2023 at 16:58):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Jul 18 2023 at 20:29):

fitzgen updated PR #6723.

Wasmtime GitHub notifications bot (Jul 19 2023 at 21:20):

fitzgen requested jameysharp for a review on PR #6723.

Wasmtime GitHub notifications bot (Jul 20 2023 at 18:06):

fitzgen requested elliottt for a review on PR #6723.

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:08):

elliottt submitted PR review:

This looks great to me, thank you for all the comments!

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:08):

elliottt submitted PR review:

This looks great to me, thank you for all the comments!

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:08):

elliottt created PR review comment:

    for i in (0..new_stack_words).rev() {

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:13):

fitzgen updated PR #6723.

Wasmtime GitHub notifications bot (Jul 21 2023 at 18:13):

fitzgen has enabled auto merge for PR #6723.

Wasmtime GitHub notifications bot (Jul 21 2023 at 20:11):

afonso360 has disabled auto merge for PR #6723.

Wasmtime GitHub notifications bot (Jul 21 2023 at 20:11):

afonso360 has enabled auto merge for PR #6723.

Wasmtime GitHub notifications bot (Jul 22 2023 at 18:37):

fitzgen merged PR #6723.

Last updated: Dec 23 2024 at 12:05 UTC