Stream: git-wasmtime

Topic: wasmtime / PR #6709 x64: Add a missing ssse3 condition to...

Wasmtime GitHub notifications bot (Jul 10 2023 at 20:18):

alexcrichton opened PR #6709 from alexcrichton:add-another-simd-guard to bytecodealliance:main:

This commit fixes a mistake from the SSE2-simd work where an SSSE3 guard was missing from a usage of pshufb. I assumed that the SSE4.1 guard was enough but a fuzz-generated test case shows that it's possible to enable SSE4.1 without SSSE3 so a second condition is added here (SSE4.1 remains for pinsrb and SSSE3 is for pshufb).

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Jul 10 2023 at 20:18):

alexcrichton requested abrown for a review on PR #6709.

Wasmtime GitHub notifications bot (Jul 10 2023 at 20:18):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6709.

Wasmtime GitHub notifications bot (Jul 10 2023 at 20:38):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Jul 10 2023 at 20:38):

abrown has enabled auto merge for PR #6709.

Wasmtime GitHub notifications bot (Jul 10 2023 at 21:26):

abrown merged PR #6709.

Last updated: Oct 23 2024 at 20:03 UTC