Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17): Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera opened PR #6703 from saulecabrera:winch-global-get-set to bytecodealliance:main:
This change adds support for the
global.setandglobal.getinstructions.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera requested cfallin for a review on PR #6703.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera requested jameysharp for a review on PR #6703.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera requested wasmtime-fuzz-reviewers for a review on PR #6703.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #6703.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:17):saulecabrera requested wasmtime-core-reviewers for a review on PR #6703.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:18):saulecabrera edited PR #6703:
Part of https://github.com/bytecodealliance/wasmtime/issues/6528
This change adds support for theglobal.setandglobal.getinstructions.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:42):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:42):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:42):fitzgen created PR review comment:
Don't see any
f32orf64globals being tested here. Are those valtypes not supported by winch at all yet? If they are supported, then there should be some exercising of globals of those types. If not, then I guess there should eventually be that same exercising but not in this PR :-p
Wasmtime GitHub notifications bot (Jul 07 2023 at 17:08):saulecabrera created PR review comment:
Yeah, not supported yet, but I'll be working on introducing support for them next.
Wasmtime GitHub notifications bot (Jul 07 2023 at 17:52):saulecabrera merged PR #6703.
Last updated: Dec 23 2024 at 12:05 UTC