Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05): Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05):alexcrichton opened PR #6702 from alexcrichton:fix-nightly-wranings to bytecodealliance:main:
- One is to avoid using
drop(&mut T)- Another is to avoid using
()in FFI functions since apparently that's not recommended. Working around this in the macro was pretty tricky, however.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05):alexcrichton requested elliottt for a review on PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05):alexcrichton requested wasmtime-compiler-reviewers for a review on PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05):alexcrichton requested jameysharp for a review on PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:05):alexcrichton requested wasmtime-core-reviewers for a review on PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 15:08):alexcrichton updated PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:25):jameysharp submitted PR review:
I can imagine it was a pain to get the macros right. I briefly tried to think about whether there's an easier or clearer way to implement the transcoders, but nah.
There are a couple of maybe-cleanups but overall this looks good to me!
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:25):jameysharp submitted PR review:
I can imagine it was a pain to get the macros right. I briefly tried to think about whether there's an easier or clearer way to implement the transcoders, but nah.
There are a couple of maybe-cleanups but overall this looks good to me!
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:25):jameysharp created PR review comment:
I wouldn't have expected
*to work here since the corresponding macro pattern is declared with?. Since there can be at most one->result declaration, can this go back to being??
Wasmtime GitHub notifications bot (Jul 07 2023 at 16:25):jameysharp created PR review comment:
Is
size_pairstill used anywhere or can this line be deleted?
Wasmtime GitHub notifications bot (Jul 07 2023 at 19:46):alexcrichton created PR review comment:
Oops, now I'm also surprised rustc didn't catch this copy/paste error of mine...
Wasmtime GitHub notifications bot (Jul 07 2023 at 19:48):alexcrichton updated PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 19:49):alexcrichton has enabled auto merge for PR #6702.
Wasmtime GitHub notifications bot (Jul 07 2023 at 20:51):alexcrichton merged PR #6702.
Last updated: Dec 23 2024 at 13:07 UTC